[Spark] Adding ConcurrentDomainMetadataException to correctly indicate conflicting domains. #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aException to accurately reflect the delta conflict. Signed-off-by: Mike Kuchenbecker <[email protected]>
spark/src/main/scala/org/apache/spark/sql/delta/ConflictChecker.scala
Outdated
Show resolved
Hide resolved
mikek-db
changed the title
allisonport-db
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ConcurrentDomainMetadataException to correctly indicate conflicting domains as compared to ConcurrentTransactionException.
Which Delta project/connector is this regarding?
Description
ConcurrentTransactionException did not correctly indicate the problem as it was intended to be used during SetTransaction. By making a new typed error we collect additional information about the conflicting operation in the context of the exception.
How was this patch tested?
build/sbt compile && build/sbt testDoes this PR introduce any user-facing changes?
Exceptions will now indicate ConcurrentDomainMetadataException rather than ConcurrentTransactionException with domain info in the string message.